Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 )
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain ...................................................................... Patch Set 4: Code-Review+1 Tim, thanks a lot for getting this done. LGTM, I'd just like other people to have the opportunity to review it too. One question: when the toolchain component comes with its own tests, do we have an accepted way of running those tests in the toolchain build on the supported platforms? I'm not saying we should start doing this now (and it could get difficult with our patches added), but something like this could serve as a sanity check, especially when new components are onboarded. -- To view, visit http://gerrit.cloudera.org:8080/9274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e Gerrit-Change-Number: 9274 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 21 Feb 2018 23:15:43 +0000 Gerrit-HasComments: No
