Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 )
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain ...................................................................... Patch Set 4: Running the test suites would be a good idea. I think we could reasonably run them as part of the build of each component. I suspect it might be a bit of work to get them to run, depending on how robust the tests are and what they assume about the environment. -- To view, visit http://gerrit.cloudera.org:8080/9274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e Gerrit-Change-Number: 9274 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Feb 2018 23:25:58 +0000 Gerrit-HasComments: No