Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9274 )
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain ...................................................................... Patch Set 4: -Code-Review As for tests, there're two executable: orc-test and tool-test. The tool-test tests the executables in tools (e.g. orc-scan, orc-metadata) which we don't depend on. Since the tests use hard codes of the tools path, they will fail by files not founded. We can disable this test by commenting out it in tools/test/CMakeLists.txt The orc-test is the exact test sets we need. By exporting the env var ORC_EXAMPLE_DIR to $NATIVE_TOOLCHAIN/source/orc/$ORC_VERSION/examples, it can run successfully. -- To view, visit http://gerrit.cloudera.org:8080/9274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e Gerrit-Change-Number: 9274 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 28 Feb 2018 06:43:43 +0000 Gerrit-HasComments: No
