Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 )
Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG@15 PS8, Line 15: REFRESH METADATA > Just thinking out loud, should we rename it to RELOAD METADATA? From a user We had few internal discussions on what name we should use. Initially it was simply "REFRESH", but then we decided to change it to "REFRESH METADATA". I guess it's to mean a privilege for both "REFRESH" and "INVALIDATE METADATA". I'm open to suggestion though. http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/main/java/org/apache/impala/authorization/Privilege.java@54 PS8, Line 54: public enum SentryAction implements Action { > Just to be sure, these Impala specific privilege grants to groups are ignor That's correct. http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@249 PS8, Line 249: roleName = "refresh_functional_alltypesagg"; > I think you could keep a single role (say "refresh_metadata_role") and keep Yup, you're right if we only consider using Sentry Service. We can easily switch between roles. With Sentry authorization policy file, we have no way of switching roles. I believe the idea to keep the roles match between Sentry Service and Sentry authorization file is for readability although it may be redundant for Sentry service. -- To view, visit http://gerrit.cloudera.org:8080/9589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4 Gerrit-Change-Number: 9589 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 15 Mar 2018 02:50:40 +0000 Gerrit-HasComments: Yes
