Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 )
Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege ...................................................................... Patch Set 9: Code-Review+1 (3 comments) Code changes look ok to me. +1 once the commit message is updated. Please raise a doc jira for this. http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG@11 PS8, Line 11: > Also please mention what was the requirement before this patch. forgot this? http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG@15 PS8, Line 15: REFRESH METADATA > Let me chime in with my 2 cents: WFM. We could also make it "METADATA REFRESH" privilege if we think users would confuse it with REFRESH command. Either wfm. http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@249 PS8, Line 249: roleName = "refresh_functional_alltypesagg"; > Yup, you're right if we only consider using Sentry Service. We can easily s Okay. let's leave it this way then, doesn't hurt to have some extra lines. -- To view, visit http://gerrit.cloudera.org:8080/9589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4 Gerrit-Change-Number: 9589 Gerrit-PatchSet: 9 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 05:38:21 +0000 Gerrit-HasComments: Yes
