Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 )
Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG@15 PS8, Line 15: REFRESH METADATA > We had few internal discussions on what name we should use. Initially it wa We need to decide what privilege name we should use, some suggestions: - REFRESH - REFRESH METADATA - RELOAD METADATA - RESET METADATA I'm more leaning into RESET METADATA since that's what we use in code: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/main/java/org/apache/impala/authorization/Privilege.java@50 PS8, Line 50: Sentry actions Impala can : * use without being tied to Hive actions since there may be privileges > slightly confused by this: does a new reader of this code need to know abou You got a point. I'll update the comment. -- To view, visit http://gerrit.cloudera.org:8080/9589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4 Gerrit-Change-Number: 9589 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 03:40:36 +0000 Gerrit-HasComments: Yes
