Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 )
Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py@23 PS2, Line 23: # 1. install basic non-C/C++ packages into the virtualenv > Is there a new stage here? Done http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py@154 PS2, Line 154: cmd.extend(["--index-url", "%s/simple" % os.environ["PYPI_MIRROR"]]) > Do you know why we use --no-index in the mirror-less case? I don't know, should we remove it? -- To view, visit http://gerrit.cloudera.org:8080/9798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85f75f1f1a305f3043e0910ab88a880eeb30f00b Gerrit-Change-Number: 9798 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 19:02:23 +0000 Gerrit-HasComments: Yes
