Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 )
Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py@154 PS2, Line 154: cmd.append("--no-index") > I was under the impression that infra/python/deps/download_requirements -> My understanding is that we're not relying on an external index to obtain the packages themselves but do rely on it for dependency resolution. I.e., we're making all dependency decisions based on the index, and then expect the resulting file to exist locally. -- To view, visit http://gerrit.cloudera.org:8080/9798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85f75f1f1a305f3043e0910ab88a880eeb30f00b Gerrit-Change-Number: 9798 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 20:36:13 +0000 Gerrit-HasComments: Yes
