David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 )
Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py@154 PS2, Line 154: cmd.extend(["--index-url", "%s/simple" % os.environ["PYPI_MIRROR"]]) > After more consideration, this should prevent us from fetching additional p I was under the impression that infra/python/deps/download_requirements -> infra/python/deps/pip_download.py was supposed to insure that we aren't relying on an external index (either public or private) by the time we get to bootstrap_virtualenv.py. Shouldn't we only be installing from pre-downloaded packages at this point? -- To view, visit http://gerrit.cloudera.org:8080/9798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85f75f1f1a305f3043e0910ab88a880eeb30f00b Gerrit-Change-Number: 9798 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 26 Mar 2018 19:50:53 +0000 Gerrit-HasComments: Yes
