Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9798 )
Change subject: IMPALA-6731: Use private index in bootstrap_virtualenv ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/9798/2/infra/python/bootstrap_virtualenv.py@154 PS2, Line 154: cmd.append("--no-index") > I don't know. Can you tell if it seems to do anything? After more consideration, this should prevent us from fetching additional packages from the index. If we forget to add some to the various requirements.txt files, this should trigger an error. However, we still seem to access the index for version/dependency resolution, hence we need to change it when using a private mirror. I updated the comment. -- To view, visit http://gerrit.cloudera.org:8080/9798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85f75f1f1a305f3043e0910ab88a880eeb30f00b Gerrit-Change-Number: 9798 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Mar 2018 19:39:49 +0000 Gerrit-HasComments: Yes
