Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 )
Change subject: IMPALA-6747: Automate diagnostics collection. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/__init__.py File bin/diagnostics/__init__.py: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/__init__.py@1 PS1, Line 1: The Rat check might trip over this file without a license header, even if it's otherwise empty (I might be wrong, please check). http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_diagnostics.py File bin/diagnostics/collect_diagnostics.py: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_diagnostics.py@54 PS1, Line 54: CDH versions <= 5.8.x This should now refer to upstream versions http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh File bin/diagnostics/collect_shared_libs.sh: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh@1 PS1, Line 1: #!/usr/bin/env bash What's the befit of this over /bin/bash? -- To view, visit http://gerrit.cloudera.org:8080/9815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29caec7c3be5b6a31e60461294979c318300f64 Gerrit-Change-Number: 9815 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 04:30:45 +0000 Gerrit-HasComments: Yes
