Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 )
Change subject: IMPALA-6747: Automate diagnostics collection. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9815/2/bin/diagnostics/collect_diagnostics.py File bin/diagnostics/collect_diagnostics.py: http://gerrit.cloudera.org:8080/#/c/9815/2/bin/diagnostics/collect_diagnostics.py@54 PS2, Line 54: bundled in CDH versions <= 5.8.x will reliably c > While this is true, Impala 2.6 has breakpad support but still crashes. The Oh, I was not aware of this. I was checking the breakpad changes and figured they are in Impala 2.6 (first release after graduation). So I just reworded it this way. I fixed it now. http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh File bin/diagnostics/collect_shared_libs.sh: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh@1 PS1, Line 1: #!/usr/bin/env bash > Thanks for the explanation. I'm leaning towards using /bin/bash here to mak As we discussed offline, we use "env bash" at multiple places in the Impala code base. So not changing it. -- To view, visit http://gerrit.cloudera.org:8080/9815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29caec7c3be5b6a31e60461294979c318300f64 Gerrit-Change-Number: 9815 Gerrit-PatchSet: 1 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 17:36:32 +0000 Gerrit-HasComments: Yes
