Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 )
Change subject: IMPALA-6747: Automate diagnostics collection. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/__init__.py File bin/diagnostics/__init__.py: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/__init__.py@1 PS1, Line 1: > The Rat check might trip over this file without a license header, even if i Good point, added it to rat-excludes. http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_diagnostics.py File bin/diagnostics/collect_diagnostics.py: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_diagnostics.py@54 PS1, Line 54: thout breakpad suppor > This should now refer to upstream versions Done. http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh File bin/diagnostics/collect_shared_libs.sh: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh@1 PS1, Line 1: #!/usr/bin/env bash > What's the befit of this over /bin/bash? It just searches the PATH for bash. So, it also works in non-default installations of bash (/bin/bash doesn't exist on some systems maybe?) Not an expert on this but I read this makes it more portable. I guess it doesn't make much difference in our environments though. More here https://stackoverflow.com/questions/16365130/the-difference-between-usr-bin-env-bash-and-usr-bin-bash -- To view, visit http://gerrit.cloudera.org:8080/9815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29caec7c3be5b6a31e60461294979c318300f64 Gerrit-Change-Number: 9815 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 05:04:31 +0000 Gerrit-HasComments: Yes
