Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9815 )
Change subject: IMPALA-6747: Automate diagnostics collection. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9815/2/bin/diagnostics/collect_diagnostics.py File bin/diagnostics/collect_diagnostics.py: http://gerrit.cloudera.org:8080/#/c/9815/2/bin/diagnostics/collect_diagnostics.py@54 PS2, Line 54: versions without breakpad support reliably crash While this is true, Impala 2.6 has breakpad support but still crashes. The distinction that you had before was correct and important, you just needed to replace Cloudera's versioning with Impala versions 2.6 (adding breakpad) and 2.7 (adding sigusr1 support). http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh File bin/diagnostics/collect_shared_libs.sh: http://gerrit.cloudera.org:8080/#/c/9815/1/bin/diagnostics/collect_shared_libs.sh@1 PS1, Line 1: #!/usr/bin/env bash > It just searches the PATH for bash. So, it also works in non-default instal Thanks for the explanation. I'm leaning towards using /bin/bash here to make sure this works even in cases where the environment has been changed. I don't feel strongly though and this likely doesn't matter. -- To view, visit http://gerrit.cloudera.org:8080/9815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib29caec7c3be5b6a31e60461294979c318300f64 Gerrit-Change-Number: 9815 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 17:22:14 +0000 Gerrit-HasComments: Yes
