Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 )
Change subject: IMPALA-6793: Fix empty metadata after statestore restarts ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9921/2/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/9921/2/be/src/catalog/catalog-server.cc@231 PS2, Line 231: // If not generating a delta update and 'pending_topic_updates_' doesn't already contain : // the full catalog (beginning with version 0), then force GatherCatalogUpdatesThread() : // to reload the full catalog. Can you expand the comment a bit to describe what happens in the case when delta.from_version == 0? http://gerrit.cloudera.org:8080/#/c/9921/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/9921/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1155 PS2, Line 1155: oldDbNames.remove(BUILTINS_DB); This is not intuitive. Plz explain what is happening here and how the builtins_db will be reconstructed. -- To view, visit http://gerrit.cloudera.org:8080/9921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0 Gerrit-Change-Number: 9921 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 03 Apr 2018 23:53:53 +0000 Gerrit-HasComments: Yes
