Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 )
Change subject: IMPALA-6793: Fix empty metadata after statestore restarts ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1157 PS3, Line 1157: oldDbNames.remove(BUILTINS_DB); > will do This is really weird and we should understand what's happening. Why are we even sending out stuff for the BUILTINS_DB? Every impalad initializes that locally and the contents are static. http://gerrit.cloudera.org:8080/#/c/9921/3/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/9921/3/tests/custom_cluster/test_restart_services.py@26 PS3, Line 26: class TestRestart(CustomClusterTestSuite): I'm worried about the flakiness of this test. I think we are missing the right metrics (e.g. statestore service id) to make this test robust. How about deferring this work until later? Developing the test will take some, but our some of our automated tests caught this bug, so it's not completely uncovered. -- To view, visit http://gerrit.cloudera.org:8080/9921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0 Gerrit-Change-Number: 9921 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 04 Apr 2018 21:46:17 +0000 Gerrit-HasComments: Yes
