Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9921 )

Change subject: IMPALA-6793: Fix empty metadata after statestore restarts
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py
File tests/custom_cluster/test_restart_services.py:

http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@42
PS2, Line 42: for retry in range(0, 10):
is there a metric to wait on, for example number of subscribers at the 
statestore and backends at the impalads (instead of a retry)?


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@44
PS2, Line 44: cursor.execute("describe database functional")
just checking, what error do you get without your fix?


http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@47
PS2, Line 47: sleep(10)
what's this sleep for in the catch?



--
To view, visit http://gerrit.cloudera.org:8080/9921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0
Gerrit-Change-Number: 9921
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
Gerrit-Comment-Date: Wed, 04 Apr 2018 00:42:21 +0000
Gerrit-HasComments: Yes

Reply via email to