Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 )
Change subject: IMPALA-6793: Fix empty metadata after statestore restarts ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/9921/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1157 PS3, Line 1157: oldDbNames.remove(BUILTINS_DB); > what is it about this change that requires this additional precaution? I haven't figured out. I spent some time on it and what I know is that without this patch the remove operation is sent out by catalog but somehow not received by impalad. I suppose removing it in this fix is safe. http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@42 PS2, Line 42: return > is there a metric to wait on, for example number of subscribers at the stat I don't think existing metrics can do that. The query is guaranteed to succeed after the first 1) *non-empty* catalog update from the 2) *new statestore* is received by impala. We can check who the current statestore is, whether the current catalog is empty, but nothing more. http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@44 PS2, Line 44: sleep(10) > just checking, what error do you get without your fix? AnalysisException: Database does not exist: functional http://gerrit.cloudera.org:8080/#/c/9921/2/tests/custom_cluster/test_restart_services.py@47 PS2, Line 47: > what's this sleep for in the catch? We don't know when the non-empty update from the new statestore will come. This sleep tries to wait for it. -- To view, visit http://gerrit.cloudera.org:8080/9921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0 Gerrit-Change-Number: 9921 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 04 Apr 2018 01:12:21 +0000 Gerrit-HasComments: Yes
