Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 )
Change subject: IMPALA-6793: Fix empty metadata after statestore restarts ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9921/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/9921/3/be/src/catalog/catalog-server.cc@256 PS3, Line 256: } > while we're here, is there something stricter we can assert about the state If statestore restarts, branch "if (delta.from_version == 0 && last_sent_catalog_version_ != 0)" will be taken, and pending_topic_updates_ will be non-empty at both L257 and L279. I guess we can remove this asynchronous catalog collecting process at some point: I think it was designed this way because statestore subscribers used to process statestore update in a line and large catalog updates may block other statestore subscribers, so adding an async BE cache makes sense. Besides, getting catalog delta from FE used to take a big lock, so it's more frequently blocked. Now that these problems are fixed by IMPALA-4953 and IMPALA-5058, there isn't a good reason to do it anymore. -- To view, visit http://gerrit.cloudera.org:8080/9921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0 Gerrit-Change-Number: 9921 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 01:26:11 +0000 Gerrit-HasComments: Yes
