Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 )
Change subject: IMPALA-6793: Fix empty metadata after statestore restarts ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9921/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/9921/3/be/src/catalog/catalog-server.cc@256 PS3, Line 256: } > If statestore restarts, branch "if (delta.from_version == 0 && last_sent_ca It also used to be the case that heartbeats were piggy-backed onto topic updates, so a long topic could lead the statestore to believe the catalogd was down. So I agree that it makes sense to revisit the async collection process, but we need to be careful. -- To view, visit http://gerrit.cloudera.org:8080/9921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0 Gerrit-Change-Number: 9921 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 05 Apr 2018 16:07:48 +0000 Gerrit-HasComments: Yes
