Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 )
Change subject: IMPALA-6793: Fix empty metadata after statestore restarts ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9921/3/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/9921/3/tests/custom_cluster/test_restart_services.py@26 PS3, Line 26: class TestRestart(CustomClusterTestSuite): > That first part is actually wrong, thanks for Vuk for clearing that up. The I mostly agree with you on logs. The metrics are almost as tightly coupled, in practice, but I think it's not a fruitful argument. I disagree with the harm argument. If it's not flaky for 12 months, then we get the benefit of the test. If it's flaky within the next month, then, yes, we'll remove the test and have to think about it harder. I think you may have specific worries about the flakiness here that aren't yet captured in this mini-thread. Are there plausible improvements that would assuage that? Do we already know that this test is flaky? I'll also note that https://issues.apache.org/jira/browse/IMPALA-6486 seems fundamentally similar to me. It looks to me like the commit that fixed IMPALA-6486 would have benefitted from a similar test. I'm quite happy to disagree, but I wanted to explain my reasoning a bit more. -- To view, visit http://gerrit.cloudera.org:8080/9921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I332a60e172af84b93b3544373fe363cdced5e8d0 Gerrit-Change-Number: 9921 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 04 Apr 2018 22:49:54 +0000 Gerrit-HasComments: Yes
