Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 )
Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation ...................................................................... Patch Set 8: (2 comments) Do we have tests for the denying the reservation increase? http://gerrit.cloudera.org:8080/#/c/9757/8/tests/query_test/test_mem_usage_scaling.py File tests/query_test/test_mem_usage_scaling.py: http://gerrit.cloudera.org:8080/#/c/9757/8/tests/query_test/test_mem_usage_scaling.py@133 PS8, Line 133: 48 that's still a bit higher than on master. http://gerrit.cloudera.org:8080/#/c/9757/8/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/9757/8/tests/query_test/test_sort.py@174 PS8, Line 174: new_vector = deepcopy(vector) : # Run with num_nodes=1 to make execution more deterministic. : new_vector.get_value('exec_option')['num_nodes'] = 1 why does this look different than e.g. lines 136-140? -- To view, visit http://gerrit.cloudera.org:8080/9757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc80e05118a9eef72cac8e2308418122e3ee0842 Gerrit-Change-Number: 9757 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 18 Apr 2018 23:09:08 +0000 Gerrit-HasComments: Yes
