Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 )
Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/9757/9/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/9757/9/be/src/exec/hdfs-scan-node.cc@286 PS9, Line 286: DCHECK(!first_thread); > I actually don't understand how this ever worked - we can bail out here if Filed IMPALA-6920. From what I can tell it can't result in any deadlocks or crashes prior to this DCHECK but it's not clear if it's desirable behaviour. -- To view, visit http://gerrit.cloudera.org:8080/9757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc80e05118a9eef72cac8e2308418122e3ee0842 Gerrit-Change-Number: 9757 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Apr 2018 22:02:04 +0000 Gerrit-HasComments: Yes
