Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9757 )
Change subject: IMPALA-6679,IMPALA-6678: reduce scan reservation ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/9757/9/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/9757/9/be/src/exec/hdfs-scan-node.cc@286 PS9, Line 286: DCHECK(!first_thread); This DCHECK can be hit because in some places the count is decremented before the thread token is released. There may be a similar bug with reservations. http://gerrit.cloudera.org:8080/#/c/9757/9/be/src/exec/hdfs-scan-node.cc@291 PS9, Line 291: // Deduct the reservation. We haven't dropped the lock since the Stale comment. -- To view, visit http://gerrit.cloudera.org:8080/9757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc80e05118a9eef72cac8e2308418122e3ee0842 Gerrit-Change-Number: 9757 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 24 Apr 2018 18:47:46 +0000 Gerrit-HasComments: Yes
