Charles Agnello has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: Added thread stackTrace summary from OpenJDK. ThreadInfo.toString restricts the number of frames to 8. The idea is to keep this configurable. A runtime flag is also available. ...................................................................... Patch Set 1: (1 comment) There is some extraneous code in the commit. http://gerrit.cloudera.org:8080/#/c/10145/1/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10145/1/fe/src/main/java/org/apache/impala/common/JniUtil.java@307 PS1, Line 307: if (i < stackTrace.length) { This "if" block is not necessary if you remove the limit on stack trace elements. -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Charles Agnello <[email protected]> Gerrit-Comment-Date: Sun, 22 Apr 2018 05:04:57 +0000 Gerrit-HasComments: Yes
