Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Just nits left. My build environment is broken this week, so I'll ask Alex Behm to give this a final +2. Thank you for your contribution! http://gerrit.cloudera.org:8080/#/c/10145/8/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10145/8/fe/src/main/java/org/apache/impala/common/JniUtil.java@280 PS8, Line 280: /p nit: here and below, our style includes spaces between comment markers and any other text. // like this //not like this http://gerrit.cloudera.org:8080/#/c/10145/8/fe/src/main/java/org/apache/impala/common/JniUtil.java@319 PS8, Line 319: result.append('\n'); nit: always combine two appends in a row. -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Charles Agnello <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Comment-Date: Mon, 30 Apr 2018 05:08:30 +0000 Gerrit-HasComments: Yes
