Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/10145/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10145/4//COMMIT_MSG@10 PS4, Line 10: whic > nit: replace with ", which " to make it clear you are talking about ThreadI nit: comma, not period, before "which". http://gerrit.cloudera.org:8080/#/c/10145/2/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10145/2/fe/src/main/java/org/apache/impala/common/JniUtil.java@296 PS2, Line 296: > This is as it is present in the implementation of ThreadInfo.toString() [lo Yes. http://gerrit.cloudera.org:8080/#/c/10145/2/fe/src/main/java/org/apache/impala/common/JniUtil.java@300 PS2, Line 300: result.append('\n'); > This is present in the implementation of ThreadInfo.toString() [Open JDK so You can achieve the same functionality with better efficiency. http://gerrit.cloudera.org:8080/#/c/10145/5/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10145/5/fe/src/main/java/org/apache/impala/common/JniUtil.java@281 PS5, Line 281: case BLOCKED: The branches are the same; use case BLOCKED: case WAITING: case TIMED_WAITING: result.append() Also, always combine two appends in a row. -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Abhishek Sharma <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Charles Agnello <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Comment-Date: Thu, 26 Apr 2018 18:53:51 +0000 Gerrit-HasComments: Yes
