Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10145/5/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/10145/5/fe/src/main/java/org/apache/impala/common/JniUtil.java@260 PS5, Line 260: StringBuilder result = new StringBuilder("\"" + threadInfo.getThreadName() + "\"" + nit: we use 2 spaces and not 4 spaces. -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Sharma <abhishek.p...@gmail.com> Gerrit-Reviewer: Abhishek Sharma <abhishek.p...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Charles Agnello <charles.w.agne...@gmail.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Thu, 26 Apr 2018 18:58:06 +0000 Gerrit-HasComments: Yes
