Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 )
Change subject: IMPALA-6913: Simple parser for Impala profile logs. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9265/3/bin/parse-thrift-profile.py File bin/parse-thrift-profile.py: http://gerrit.cloudera.org:8080/#/c/9265/3/bin/parse-thrift-profile.py@60 PS3, Line 60: thrift = possibly_compressed nit: Check for specific error code Z_DATA_ERROR, else raise? http://gerrit.cloudera.org:8080/#/c/9265/3/bin/parse-thrift-profile.py@65 PS3, Line 65: print tree How about printing a JSON instead? That is more readable. -- To view, visit http://gerrit.cloudera.org:8080/9265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1174c65b002f9b71eccb0b56f875449f00eae39 Gerrit-Change-Number: 9265 Gerrit-PatchSet: 3 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 24 Apr 2018 04:05:32 +0000 Gerrit-HasComments: Yes
