David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 )
Change subject: IMPALA-6913: Simple parser for Impala profile logs. ...................................................................... Patch Set 4: > Patch Set 3: > > (2 comments) > > I added a tiny bit of cmdline parsing to allow specifying input not via > stdin. > I added this as I was looking at the exception handling and decided > to keep it. Just an FYI -- there is something very similar to this in Impala-aux already. I don't recall who wrote it, or if anyone still uses it. Just pointing out its existence. -- To view, visit http://gerrit.cloudera.org:8080/9265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1174c65b002f9b71eccb0b56f875449f00eae39 Gerrit-Change-Number: 9265 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Apr 2018 19:48:03 +0000 Gerrit-HasComments: No
