Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 )
Change subject: IMPALA-6913: Simple parser for Impala profile logs. ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9265/4/bin/parse-thrift-profile.py File bin/parse-thrift-profile.py: http://gerrit.cloudera.org:8080/#/c/9265/4/bin/parse-thrift-profile.py@33 PS4, Line 33: # | head -n 1 | awk '{ print $3 }' | parse-profile.py > Could you add the file example too. Done http://gerrit.cloudera.org:8080/#/c/9265/4/bin/parse-thrift-profile.py@45 PS4, Line 45: or sys.argv[1] == "-": > Why this? Whats so specific about "-"? "-" is commonly used to indicate "stdin". For example # - indicates read from stdin $echo hi | cat - hi vs # Read a file; ignore stdin $echo hi | cat /dev/null See the answers for https://unix.stackexchange.com/questions/16357/usage-of-dash-in-place-of-a-filename. -- To view, visit http://gerrit.cloudera.org:8080/9265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1174c65b002f9b71eccb0b56f875449f00eae39 Gerrit-Change-Number: 9265 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 25 Apr 2018 20:59:34 +0000 Gerrit-HasComments: Yes
