Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9265 )
Change subject: IMPALA-6913: Simple parser for Impala profile logs. ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9265/3/bin/parse-thrift-profile.py File bin/parse-thrift-profile.py: http://gerrit.cloudera.org:8080/#/c/9265/3/bin/parse-thrift-profile.py@60 PS3, Line 60: base64_encoded = space_separated[0] > I couldn't find anything in the documentation that was particularly clear. I see. Ok. http://gerrit.cloudera.org:8080/#/c/9265/3/bin/parse-thrift-profile.py@65 PS3, Line 65: try: > Do you have a snippet that would do the trick? I wasn't able to find one qu We could do something like this, serialize(tree, protocol_factory=TJSONProtocol.TJSONProtocolFactory()) but TJSONProtocol is in 0.9.1 and later. So don't think we can use that. Nvm. http://gerrit.cloudera.org:8080/#/c/9265/4/bin/parse-thrift-profile.py File bin/parse-thrift-profile.py: http://gerrit.cloudera.org:8080/#/c/9265/4/bin/parse-thrift-profile.py@33 PS4, Line 33: # | head -n 1 | awk '{ print $3 }' | parse-profile.py Could you add the file example too. http://gerrit.cloudera.org:8080/#/c/9265/4/bin/parse-thrift-profile.py@45 PS4, Line 45: or sys.argv[1] == "-": Why this? Whats so specific about "-"? -- To view, visit http://gerrit.cloudera.org:8080/9265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1174c65b002f9b71eccb0b56f875449f00eae39 Gerrit-Change-Number: 9265 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 24 Apr 2018 22:10:49 +0000 Gerrit-HasComments: Yes
