Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20506 )

Change subject: IMPALA-12465: Unicode column name support
......................................................................


Patch Set 5:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py
File tests/metadata/column-unicode.py:

http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@3
PS5, Line 3: c
flake8: E501 line too long (147 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@19
PS5, Line 19: a
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@19
PS5, Line 19: a
flake8: W504 line break after binary operator


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@20
PS5, Line 20: i
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@21
PS5, Line 21: #
flake8: E116 unexpected indentation (comment)


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@21
PS5, Line 21: s
flake8: E501 line too long (107 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@24
PS5, Line 24: e
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/metadata/column-unicode.py@24
PS5, Line 24:
flake8: W292 no newline at end of file


http://gerrit.cloudera.org:8080/#/c/20506/5/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/20506/5/tests/shell/test_shell_interactive.py@389
PS5, Line 389: E
flake8: E501 line too long (99 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/20506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718
Gerrit-Change-Number: 20506
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 23 Nov 2023 06:50:51 +0000
Gerrit-HasComments: Yes

Reply via email to