Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20785 )
Change subject: IMPALA-12581: Fix issue of ILIKE and IREGEXP don't work correctly with non-const pattern ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20785/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20785/2//COMMIT_MSG@7 PS2, Line 7: don't work nit: not working http://gerrit.cloudera.org:8080/#/c/20785/2//COMMIT_MSG@16 PS2, Line 16: fix nit: fixing http://gerrit.cloudera.org:8080/#/c/20785/2/be/src/exprs/like-predicate.cc File be/src/exprs/like-predicate.cc: http://gerrit.cloudera.org:8080/#/c/20785/2/be/src/exprs/like-predicate.cc@186 PS2, Line 186: state Should we set the default value for state->case_sensitive_ in this case? -- To view, visit http://gerrit.cloudera.org:8080/20785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d66680f5a7660e6a41859754c4230f276e66712 Gerrit-Change-Number: 20785 Gerrit-PatchSet: 2 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2023 19:03:29 +0000 Gerrit-HasComments: Yes
