Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20785 )
Change subject: IMPALA-12581: Fix issue of ILIKE and IREGEXP not working correctly with non-const pattern ...................................................................... Patch Set 2: (4 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/20785/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20785/2//COMMIT_MSG@7 PS2, Line 7: don't work > nit: not working Done http://gerrit.cloudera.org:8080/#/c/20785/2//COMMIT_MSG@16 PS2, Line 16: fix > nit: fixing Done http://gerrit.cloudera.org:8080/#/c/20785/2/be/src/exprs/like-predicate.cc File be/src/exprs/like-predicate.cc: http://gerrit.cloudera.org:8080/#/c/20785/2/be/src/exprs/like-predicate.cc@186 PS2, Line 186: state > Should we set the default value for state->case_sensitive_ in this > case? I think it might not be necessary because this value seems to be useless in RegexpLikeInternal(), or did I miss something? http://gerrit.cloudera.org:8080/#/c/20785/2/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/20785/2/tests/query_test/test_exprs.py@316 PS2, Line 316: "SELECT count(*) FROM {0} WHERE 'ABC' ILIKE pattern_str".format(tbl_name)) > Is there a transposed version we should test where the literal is > on the right-hand side? Did you mean testing cases where the pattern is literal, like "WHERE str_val ILIKE '%b%'"? If so, it should be unnecessary as this scenario was already being handled correctly before this patch. The issue seems to only arises when the pattern is non-constant. If you meant something else, please let me know. -- To view, visit http://gerrit.cloudera.org:8080/20785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d66680f5a7660e6a41859754c4230f276e66712 Gerrit-Change-Number: 20785 Gerrit-PatchSet: 2 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 14 Dec 2023 08:59:58 +0000 Gerrit-HasComments: Yes
