Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20785 )

Change subject: IMPALA-12581: Fix issue of ILIKE and IREGEXP don't work 
correctly with non-const pattern
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20785/2/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:

http://gerrit.cloudera.org:8080/#/c/20785/2/tests/query_test/test_exprs.py@316
PS2, Line 316:         "SELECT count(*) FROM {0} WHERE 'ABC' ILIKE 
pattern_str".format(tbl_name))
Is there a transposed version we should test where the literal is on the 
right-hand side?



--
To view, visit http://gerrit.cloudera.org:8080/20785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d66680f5a7660e6a41859754c4230f276e66712
Gerrit-Change-Number: 20785
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 13 Dec 2023 20:19:24 +0000
Gerrit-HasComments: Yes

Reply via email to