Hello Peter Rozsa, Wenzhe Zhou, Michael Smith, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20785

to look at the new patch set (#4).

Change subject: IMPALA-12581: Fix issue of ILIKE and IREGEXP not working 
correctly with non-const pattern
......................................................................

IMPALA-12581: Fix issue of ILIKE and IREGEXP not working correctly with 
non-const pattern

This patch fixes the issue where ILIKE and IREGEXP couldn't ignore case
when encountering non-constant patterns.
For example, 'SELECT 'ABC' ILIKE pattern FROM tbl' would return false
when the pattern in tbl is '%b%'.

Tests:
 - Add TestNonConstPatternILike to test_exprs.py to verify the
   effectiveness of the fixing.

Change-Id: I3d66680f5a7660e6a41859754c4230f276e66712
---
M be/src/exprs/like-predicate.cc
M be/src/exprs/like-predicate.h
M tests/query_test/test_exprs.py
3 files changed, 38 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/20785/4
--
To view, visit http://gerrit.cloudera.org:8080/20785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d66680f5a7660e6a41859754c4230f276e66712
Gerrit-Change-Number: 20785
Gerrit-PatchSet: 4
Gerrit-Owner: Zihao Ye <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>

Reply via email to