Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20695 )
Change subject: IMPALA-12495: Describe statement for Iceberg metadata tables ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Just a nit, otherwise looks good. http://gerrit.cloudera.org:8080/#/c/20695/8/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/20695/8/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3613 PS8, Line 3613: * 'tblRefPath' parameter has to be an IcebergMetadataTable reference path. We should mention the return value too. -- To view, visit http://gerrit.cloudera.org:8080/20695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe22f271a59a6885035991c09b5101193ade6e97 Gerrit-Change-Number: 20695 Gerrit-PatchSet: 8 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Jan 2024 13:22:06 +0000 Gerrit-HasComments: Yes
