Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20695 )
Change subject: IMPALA-12495: Describe statement for Iceberg metadata tables ...................................................................... Patch Set 6: (3 comments) Thank you for the reviews! http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java: http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@96 PS5, Line 96: path_ = analyzer.resolvePath(rawPath_, PathType.ANY); : } catch (AnalysisException ae) { : / > Would it be possible to move 'isIcebergMetadataTable(rawPath_)' and 'analyz Done, moved it to getTable, LMK your thoughts. http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/service/Frontend.java@1657 PS5, Line 1657: > Did you add a precondition for it? I still can't see anywhere if we check ' Done http://gerrit.cloudera.org:8080/#/c/20695/5/fe/src/main/java/org/apache/impala/service/Frontend.java@1664 PS5, Line 1664: > Should we add precondition check that this is set? I cannot hurt. Done. -- To view, visit http://gerrit.cloudera.org:8080/20695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe22f271a59a6885035991c09b5101193ade6e97 Gerrit-Change-Number: 20695 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 02 Jan 2024 14:58:10 +0000 Gerrit-HasComments: Yes
