Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20695 )
Change subject: IMPALA-12495: Describe statement for Iceberg metadata tables ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20695/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/20695/7/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3567 PS7, Line 3567: addMetadataVirtualTable Couldn't 'addMetadataVirtualTable()' return 'catalogTable' and 'virtualTable' so that we don't have to look up the cache on L3568? Do you think it would make sense? -- To view, visit http://gerrit.cloudera.org:8080/20695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe22f271a59a6885035991c09b5101193ade6e97 Gerrit-Change-Number: 20695 Gerrit-PatchSet: 7 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 02 Jan 2024 16:16:37 +0000 Gerrit-HasComments: Yes
