Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20695 )
Change subject: IMPALA-12495: Describe statement for Iceberg metadata tables ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20695/7/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java File fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java: http://gerrit.cloudera.org:8080/#/c/20695/7/fe/src/main/java/org/apache/impala/analysis/DescribeTableStmt.java@155 PS7, Line 155: analyzeIcebergMetadataTable This function no longer does analysis. It could be renamed to something like 'checkMinimalForIcebergMetadataTable()'. http://gerrit.cloudera.org:8080/#/c/20695/7/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/20695/7/fe/src/main/java/org/apache/impala/service/Frontend.java@65 PS7, Line 65: import org.apache.hadoop.hive.metastore.events.PreAlterTableEvent; Seems to be unused. http://gerrit.cloudera.org:8080/#/c/20695/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/20695/7/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@459 PS7, Line 459: STRUCT Nit: not only STRUCT types are queried but also collection types (in which case we expect errors). -- To view, visit http://gerrit.cloudera.org:8080/20695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe22f271a59a6885035991c09b5101193ade6e97 Gerrit-Change-Number: 20695 Gerrit-PatchSet: 7 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 02 Jan 2024 16:07:28 +0000 Gerrit-HasComments: Yes
