Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20956 )
Change subject: IMPALA-12747: Atomic update of execution state ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@33 PS2, Line 33: DEFINE_string DEFINE_string_hidden feels better for debugging purpose. http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@99 PS2, Line 99: move Is move required here? Or is it for performance reason? http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@119 PS2, Line 119: RETURN_IF_ERROR(DoFrontendPlanning(query_ctx)); Should this dump external_exec_request instead? http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/service/client-request-state.cc@317 PS2, Line 317: default: Handle TStmtType.UNKNOWN with distinct error message. http://gerrit.cloudera.org:8080/#/c/20956/2/bin/tsan-suppressions.txt File bin/tsan-suppressions.txt: http://gerrit.cloudera.org:8080/#/c/20956/2/bin/tsan-suppressions.txt@47 PS2, Line 47: : # TODO: IMPALA-12757: TSAN flags lock-order-inversion during internal-server-test Mention the open issue link here. https://github.com/google/sanitizers/issues/814 http://gerrit.cloudera.org:8080/#/c/20956/2/common/thrift/Types.thrift File common/thrift/Types.thrift: http://gerrit.cloudera.org:8080/#/c/20956/2/common/thrift/Types.thrift@104 PS2, Line 104: UNKNOWN = 0 Reordering enum has issue in the past https://github.com/apache/impala/commit/91d8a8f6280b2b802fe8ccc52251937c5a415766 Maybe better if UNKNOWN = 9 and keep others unchanged. In turn, TExecRequest in Frontend.thrift can be initialized like this: struct TExecRequest { 1: required Types.TStmtType stmt_type = TStmtType.UNKNOWN -- To view, visit http://gerrit.cloudera.org:8080/20956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a967c5c84b6a401f8f5764373f6cd7ee807545f Gerrit-Change-Number: 20956 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 00:01:09 +0000 Gerrit-HasComments: Yes
