Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20956 )
Change subject: IMPALA-12747: Atomic update of execution state ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@96 PS2, Line 96: ExecEnv::GetInstance()->frontend()->GetExecRequest(query_ctx, &exec_request))); > DoFrontendPlanning is only called from SetExternalPlan when the flag is set Ah, I missed that this function is only called when the flag is set. http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@113 PS2, Line 113: const TQueryCtx& query_ctx, TExecRequest external_exec_request) { > SetExternalPlan was previously a const&, so that can't have happened. Ok, I'm following what is happening now. -- To view, visit http://gerrit.cloudera.org:8080/20956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a967c5c84b6a401f8f5764373f6cd7ee807545f Gerrit-Change-Number: 20956 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 00:36:08 +0000 Gerrit-HasComments: Yes
