Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20956 )
Change subject: IMPALA-12747: Atomic update of execution state ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@96 PS2, Line 96: ExecEnv::GetInstance()->frontend()->GetExecRequest(query_ctx, &exec_request))); When SetExternalPlan() calls this function, the built-in planner will always run because of this code. However, the built-in planner should only run when FLAGS_dump_exec_request_path is set so the two plans can be compared. http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@99 PS2, Line 99: exec_request_.reset(new TExecRequest(move(exec_request))); This line of code does extra work when SetExternalPlan() calls this function because, after this function is done, SetExternalPlan() also calls exec_request_.reset() using the TExecRequest it was passed from the external planner. http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@113 PS2, Line 113: const TQueryCtx& query_ctx, TExecRequest external_exec_request) { Tracing back up the stack, external_exec_request needs to be passed by reference because this call - https://github.com/apache/impala/blob/c14156eb3a95036d07ae684a046cf15c220066a5/be/src/service/impala-server.cc#L1349 - reads the query id that was set in line 125 of this function. -- To view, visit http://gerrit.cloudera.org:8080/20956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a967c5c84b6a401f8f5764373f6cd7ee807545f Gerrit-Change-Number: 20956 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 26 Jan 2024 00:05:50 +0000 Gerrit-HasComments: Yes
