Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20956 )

Change subject: IMPALA-12747: Atomic update of execution state
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc
File be/src/runtime/query-driver.cc:

http://gerrit.cloudera.org:8080/#/c/20956/2/be/src/runtime/query-driver.cc@119
PS2, Line 119: RETURN_IF_ERROR(DoFrontendPlanning(query_ctx));
> That happens later at line 141. This dumps the plan that would have been ge
Ack


http://gerrit.cloudera.org:8080/#/c/20956/2/bin/tsan-suppressions.txt
File bin/tsan-suppressions.txt:

http://gerrit.cloudera.org:8080/#/c/20956/2/bin/tsan-suppressions.txt@47
PS2, Line 47:
            : # TODO: IMPALA-12757: TSAN flags lock-order-inversion during 
internal-server-test
> I'm actually not sure that's related. I'd rather track it in the ticket as
Ack



--
To view, visit http://gerrit.cloudera.org:8080/20956
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a967c5c84b6a401f8f5764373f6cd7ee807545f
Gerrit-Change-Number: 20956
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 26 Jan 2024 00:43:36 +0000
Gerrit-HasComments: Yes

Reply via email to