Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 )
Change subject: IMPALA-12426: Adds the Impala built-in functions prettyprint_duration and prettyprint_memory. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21038/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/21038/2/be/src/exprs/expr-test.cc@4353 PS2, Line 4353: TestStringValue("prettyprint_duration(123456789012)", "34h17m"); Can you add test with min and max value of BIGINT (-9223372036854775808 and 9223372036854775807) please? https://impala.apache.org/docs/build/html/topics/impala_bigint.html Same comment for prettyprint_memory test below. -- To view, visit http://gerrit.cloudera.org:8080/21038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 Feb 2024 22:12:46 +0000 Gerrit-HasComments: Yes
