Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 )
Change subject: IMPALA-12426: New built-in prettyprint functions for bytes and duration. ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21038/5/tests/query_test/test_prettyprint_bytes.py File tests/query_test/test_prettyprint_bytes.py: http://gerrit.cloudera.org:8080/#/c/21038/5/tests/query_test/test_prettyprint_bytes.py@22 PS5, Line 22: class TestPrettyPrintBytes(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21038/5/tests/query_test/test_prettyprint_bytes.py@30 PS5, Line 30: o flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/21038/5/tests/query_test/test_prettyprint_duration.py File tests/query_test/test_prettyprint_duration.py: http://gerrit.cloudera.org:8080/#/c/21038/5/tests/query_test/test_prettyprint_duration.py@22 PS5, Line 22: class TestPrettyPrintDuration(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21038/5/tests/query_test/test_prettyprint_duration.py@30 PS5, Line 30: o flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/21038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 20 Feb 2024 20:29:39 +0000 Gerrit-HasComments: Yes
