Hello Andrew Sherman, Riza Suminto, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21038

to look at the new patch set (#3).

Change subject: IMPALA-12426: Adds the Impala built-in functions 
prettyprint_duration and prettyprint_memory.
......................................................................

IMPALA-12426: Adds the Impala built-in functions prettyprint_duration and 
prettyprint_memory.

The prettyprint_duration function takes a numeric input
containing a number of microseconds and returns a human
readable value breaking down the input by hours, minutes,
seconds, milliseconds, microseconds, and nanoseconds.

The prettyprint_memory function takes a numeric input
containing a number of bytes and returns a human readable
values breaking down the input by gigabytes, megabytes,
kilobytes, and bytes.

Functionality tests were added to the existing expr-test
suite that tests built-in functions.

Functional-query workloads were added in two new .test
files under the testdata directory to exercise these two
new functions.

Benchmarks were added to
expr-benchmark, and new benchmarks were generated with a
release build running on a machine with the cpu
Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz

Documentation was added to the built-in functions docs.

Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
M docs/topics/impala_functions.xml
M docs/topics/impala_string_functions.xml
A 
testdata/workloads/functional-query/queries/QueryTest/prettyprint-duration.test
A testdata/workloads/functional-query/queries/QueryTest/prettyprint-memory.test
9 files changed, 549 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/21038/3
--
To view, visit http://gerrit.cloudera.org:8080/21038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913
Gerrit-Change-Number: 21038
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>

Reply via email to