Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21038 )
Change subject: IMPALA-12426: Adds the Impala built-in functions prettyprint_duration and prettyprint_memory. ...................................................................... Patch Set 2: (1 comment) Looks good. As these are functions that are callable from sql, we should have at least some simple tests that exercise 'select prettyprint_memory(1024 * 1024)' or whatever. These could be in a .test file as they are pretty simple. http://gerrit.cloudera.org:8080/#/c/21038/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21038/2//COMMIT_MSG@8 PS2, Line 8: prettyprint_duration and prettyprint_memory. Second line should be blank, it's OK to make the title line longer. -- To view, visit http://gerrit.cloudera.org:8080/21038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76632ce21ad2ca5df474160338699a542a6913 Gerrit-Change-Number: 21038 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 Feb 2024 23:21:37 +0000 Gerrit-HasComments: Yes
