Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21409 )
Change subject: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21409/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21409/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-13018: Block push down of conjuncts with implicit casting on base columns for jdbc tables > Maybe update the title to something generic, since this applies to other qu Done. http://gerrit.cloudera.org:8080/#/c/21409/1//COMMIT_MSG@17 PS1, Line 17: But casting to Date/Timestamp for a column cannot be pushed down to JDBC > I'm wondering if this applies to other non Date/Timestamp types also? Can w All explicate castings on base columns are not allowed in current implementation so CAST (stringCol AS INT) >= 1234 will not be pushed down. For Between, planner generate implicate casting between compatible data types. Since string and integer are not compatible types, exception will be thrown if comparing string with integer, like stringCol >= 1234 or stringCol >= cast("1234" as INT). We should allow implicate casting between compatible data types other than date/timestamp, like numeric data types. For safety, unsafe casting will be blocked. -- To view, visit http://gerrit.cloudera.org:8080/21409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd7e28b8d5f11f25a000dc4c9ab65895056b572 Gerrit-Change-Number: 21409 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2024 19:13:04 +0000 Gerrit-HasComments: Yes
